Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-v0.74.x] Fix wrong shell in release task #2531

Merged
merged 1 commit into from
Jan 23, 2025
Merged

[release-v0.74.x] Fix wrong shell in release task #2531

merged 1 commit into from
Jan 23, 2025

Conversation

tekton-robot
Copy link
Contributor

This is an automated cherry-pick of #2466

/assign jkhelil

Your release note here

@afrittoli
Fix wrong shell in release task
6edd8b4 
And make some files KUBE_DISTRO specific to avoid clash between
publish tasks running in parallel with different KUBE_DISTRO

Signed-off-by: Andrea Frittoli <[email protected]>
@tekton-robot tekton-robot mentioned this pull request Jan 23, 2025
Merged
4 tasks
@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jan 23, 2025
@tekton-robot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign piyush-garg after the PR has been reviewed.
You can assign the PR to them by writing /assign @piyush-garg in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 23, 2025
@tekton-robot
Copy link
Contributor Author

@tekton-robot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-tekton-operator-integration-tests 6edd8b4 link true /test pull-tekton-operator-integration-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jkhelil jkhelil merged commit 5a51b02 into tektoncd:release-v0.74.x Jan 23, 2025
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkhelil jkhelil Awaiting requested review from jkhelil

@piyush-garg piyush-garg Awaiting requested review from piyush-garg

Assignees

@jkhelil jkhelil

Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tekton-robot @jkhelil @afrittoli