-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize challenge handling #171
Open
diLLec
wants to merge
16
commits into
telekom-mms:main
Choose a base branch
from
diLLec:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Martin Schurz <[email protected]>
Signed-off-by: Martin Schurz <[email protected]>
Signed-off-by: Martin Schurz <[email protected]>
ACME providers seam to have slightly different formats in the Response when validation a process already has started for a domain. To be more flexible on that, this change adds the find_challenges filter plugin which parses the data into a standardized format for the challenge provider task modules
The test are clean now, except for the http-challenge-local.yml test. The file (located in /tmp) outputs a dns challenge instead of a http challenge as expected. I did not find the file inside of the repository, so I suspect it to be created inside of the github actions somehow. Please support me to fix this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ACME providers seam to have slightly different formats in the Response when validation a process already has started for a domain. To be more flexible on that, this change adds the find_challenges filter plugin which parses the data into a standardized format for the challenge provider task modules.
While other providers always seam to publish the challenges in the
challenge_data
field of the response, the telesec ACME API will only put the information tochallenge_date
when the certificate is new or if it has reached it's due date - only that one time. Therefore re-running the module to renew the certificate anytime before the due date or withacme_force_renewal: true
will need the token information out of theauthorizations
field of the response.I have attached a sample dataset into
tests/integration/targets/acme_letsencrypt/find-challenge-filter-plugin.yml
for reference.Alltogether the following changes are introduced:
find_challenges.py
filter plugin which will honor thechallenge_data_type
acme_challenge_data
dict increate-challenge.yml
acme_challenge_data[domain]
variable instead ofacme_challenge['challenge_data'][domain]
in challenge providers