Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Pod annotations serialized without qoutes #595

Open
slavb18 opened this issue Oct 16, 2024 · 1 comment
Open

[Bug] Pod annotations serialized without qoutes #595

slavb18 opened this issue Oct 16, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@slavb18
Copy link

slavb18 commented Oct 16, 2024

What are you really trying to do?

I want to setup pod annotations using values.yaml for step-ca

Describe the bug

Example values.yaml:

schema:
  podAnnotations:
    autocert.step.sm/mode: "0600"
server:
  podAnnotations:
    autocert.step.sm/mode: "0600"

In Job I see right result with quotes "0600"

      annotations:
        autocert.step.sm/mode: "0600"

In Deployment created from temporal/templates/server-deployment.yaml result is wrong:

      annotations:
         autocert.step.sm/mode: 0600

Minimal Reproduction

run helm install --namespace temporal --dry-run --repo https://go.temporal.io/helm-charts -f values.yaml temporal temporal --timeout 900s --create-namespace

Environment/Versions

  • OS and processor: Linux
  • Temporal Version: 1.25.1 / helm chart 0.50.0

I think bug in temporal.resourceAnnotations, and Job template working correct becouse it not uses temporal.resourceAnnotations

@slavb18 slavb18 added the bug Something isn't working label Oct 16, 2024
@slavb18
Copy link
Author

slavb18 commented Oct 29, 2024

With this bug I cannot deploy temporal with "mode" annotations, due to error

│       * Deployment in version "v1" cannot be handled as a Deployment: json: cannot unmarshal number into Go struct field ObjectMeta.spec.template.metadata.annotations of type string

slavb18 added a commit to iconicompany/iconicluster that referenced this issue Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant