-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cloud sql proxy to admin tools deployment [Issue #263] #259
base: main
Are you sure you want to change the base?
Conversation
@skyfoxs thanks for the PR! |
@tsurdilo done |
This looks good to me. |
Just wanted to point out this sidecar support (regardless of whether cloudsqlproxy is the intent) is already in other temporal service helm charts (#107). Maybe that'll help merge it in :) |
Any chance we can get this merged? I need it myself! Also the sidecar is needed in the schema-setup jobs, since they require access to cloudsql as well; I'll see about adding that and making a PR for it. |
Any update on this and did you get around to making PR for the changes @kuzmik ? |
We worked around it by adding extra sidecars in the jsonnet (we use argo to manage k8s deployments, and the jsonnet repo loads helm charts and adapts them via code). Originally I had adapted this PR to include the sidecars https://github.com/temporalio/helm-charts/pull/259/files; but since we generally prefer not to modify the helm charts in our repo if we can avoid it, I converted it to the sonnet stuff.
for example. |
Please adjust this to add and use admintools.sidecarContainers instead. |
What was changed
Add Cloud SQL proxy sidecar to the admin tools deployment.
Why?
To make Cloud SQL proxy available to the admin tools pod. So we can use the
temporal-cassandra-tool
andtemporal-sql-tool
to connect to the database like the others deployed byserver-deployment.yaml
and don't have to build it on our machine.Checklist
Closes
Close Add cloud sql proxy to admin tools deployment #263
How was this tested:
Set up and install with sidecar containers as usual. Then shell into admin-tools and connect database with
temporal-sql-tool
.Any docs updates needed?
No