Add resources for admin tools containers and creating network policies #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey guys, do you have any update? |
underrun
reviewed
Apr 26, 2023
| {{- $serviceValues := index $.Values.server $service }} | ||
| - protocol: TCP | ||
| port: {{ $serviceValues.service.port }} | ||
| {{- end }} |
There was a problem hiding this comment.
does this work if fontend, history, matching and worker all share the same port?
|
I'm happy to work with you on getting this merged, but please rebase against current master branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
This PR add option to create NetworkPolicies and add recources for admintools containers.
Why?
In our company we use network policies in k8s clusters how must have option for all services.
Also within out clusters we have Kyverno that checking recources for all containers.
Closes
How was this tested:
It has tested in our k8s cluster.
I think nothing need to update.