Print annotation and label value as YAML to support array string values #589
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
This PR adds support for array strings as annotations and labels.
Why?
Annotations and labels with array string as value (e.g.
ad.datadoghq.com/temporal-web.logs: '[{"source":"temporal","service":"temporal-web"}]'
) results in an error, both on installation and upgrade.Error message:
Error: UPGRADE FAILED: cannot patch "temporal-admintools" with kind Deployment: "" is invalid: patch: Invalid value: "{...}": json: cannot unmarshal array into Go struct field ObjectMeta.spec.template.metadata.annotations of type string
Checklist
Automated.
Or manual via:
helm install -f values.yaml --set web.podAnnotations.arrayannotation='[{"test":"true"}]' debug . --dry-run --debug
No.