Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some unit tests. #610

Merged
merged 6 commits into from
Nov 21, 2024
Merged

Add some unit tests. #610

merged 6 commits into from
Nov 21, 2024

Conversation

robholland
Copy link
Contributor

@robholland robholland commented Nov 19, 2024 •
edited
Loading

What was changed

Add some unit tests.

Why?

These are more succinct and much faster than the terratest unit tests.

Checklist

  1. Closes

  2. How was this tested:

  1. Any docs updates needed?

@robholland
Add some unit tests.
79c2e7e 
These are more succinct and much faster than the terratest tests.
@robholland robholland requested a review from a team as a code owner November 19, 2024 14:41
tomwheeler
tomwheeler approved these changes Nov 21, 2024
View reviewed changes
Copy link

@tomwheeler tomwheeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I attempted to run this last night, but it failed. I pulled again this morning and found that the update made in the most recent commit fixed it.

@robholland robholland merged commit 4d90e8a into main Nov 21, 2024
3 checks passed
@robholland robholland deleted the rh-unittest branch November 21, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomwheeler tomwheeler tomwheeler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robholland @tomwheeler