never allow drainage info to be nil if the version stopped accepting new workflows #7343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShahabT
reviewed
Feb 14, 2025
| d.syncSummary(ctx) | ||
| } else { | ||
| mergedInfo.Status = d.VersionState.DrainageInfo.Status | ||
| mergedInfo.LastChangedTime = d.VersionState.DrainageInfo.LastChangedTime |
There was a problem hiding this comment.
Should change the child wf to not send a singal at the beginning now? it's awkward for LastCheckedTime to change a few milliseconds.
ShahabT
reviewed
Feb 14, 2025
| @@ -233,6 +236,14 @@ func (d *VersionWorkflowRunner) handleUpdateVersionMetadata(ctx workflow.Context | |||
| } | |||
|
|
|||
| func (d *VersionWorkflowRunner) startDrainage(ctx workflow.Context, isCan bool) { | |||
| if d.VersionState.GetDrainageInfo().GetStatus() == enumspb.VERSION_DRAINAGE_STATUS_UNSPECIFIED { | |||
| now := timestamppb.New(workflow.Now(ctx)) | |||
| d.VersionState.DrainageInfo = &deploymentpb.VersionDrainageInfo{ | |||
There was a problem hiding this comment.
hopefully no logic depends on VersionState.DrainageInfo otherwise we have to patch.
There was a problem hiding this comment.
I remember making sure that everything did VersionState.GetDrainageInfo().GetStatus() so it /should/ just say unspecified if it's nil due to the gap between child starting and signal arriving
There was a problem hiding this comment.
I mean workflow patch for NDE
ShahabT
reviewed
Feb 14, 2025
| @@ -62,17 +61,6 @@ func DrainageWorkflow( | |||
|
|
|||
| // Set status = DRAINING and then sleep for visibilityGracePeriod (to let recently-started workflows arrive in visibility) | |||
| if !args.IsCan { // skip if resuming after the parent continued-as-new | |||
| parentWf := workflow.GetInfo(ctx).ParentWorkflowExecution | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Set version to
DRAININGbefore starting child instead of relying on child's signalWhy?
How did you test it?
Potential risks
Documentation
Is hotfix candidate?