Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Making poller history a dynamic config #7344

Merged
merged 6 commits into from
Feb 14, 2025
Merged

Making poller history a dynamic config #7344

merged 6 commits into from
Feb 14, 2025
+33 −16

Conversation

Shivs11
Copy link
Member

@Shivs11 Shivs11 commented Feb 14, 2025

What changed?

  • PollerHistoryTTL is now a dynamic config

Why?

  • Versioning-3.1 tests required setting a low value for this config in order for some tests to work - right now, those tests were excluded from CI runs and that's not good.

How did you test it?

  • Unskipped the tests that were being skipped previously.

Potential risks

Documentation

Is hotfix candidate?

@Shivs11 Shivs11 requested a review from a team as a code owner February 14, 2025 14:17
dnr
dnr reviewed Feb 14, 2025
View reviewed changes
common/dynamicconfig/constants.go Outdated Show resolved Hide resolved
service/matching/physical_task_queue_manager.go Outdated Show resolved Hide resolved
@Shivs11 Shivs11 requested a review from dnr February 14, 2025 19:53
dnr
dnr approved these changes Feb 14, 2025
View reviewed changes
service/matching/physical_task_queue_manager.go Outdated Show resolved Hide resolved
@Shivs11 Shivs11 merged commit 9669f3a into main Feb 14, 2025
50 checks passed
@Shivs11 Shivs11 deleted the ss/poller-history-dynamic-config branch February 14, 2025 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnr dnr dnr approved these changes

@ShahabT ShahabT ShahabT approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Shivs11 @dnr @ShahabT