Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update time_series.ipynb #2284

Closed
wants to merge 1 commit into from
Closed

Conversation

Muneeb21-hub
Copy link

indices not indexes

indices not indexes
@Muneeb21-hub Muneeb21-hub requested a review from a team as a code owner November 9, 2023 16:18
Copy link

google-cla bot commented Nov 9, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link

github-actions bot commented Nov 9, 2023

Preview

Preview and run these notebook edits with Google Colab: Rendered notebook diffs available on ReviewNB.com.

Format and style

Use the TensorFlow docs notebook tools to format for consistent source diffs and lint for style:
$ python3 -m pip install -U --user git+https://github.com/tensorflow/docs

$ python3 -m tensorflow_docs.tools.nbfmt notebook.ipynb
$ python3 -m tensorflow_docs.tools.nblint --arg=repo:tensorflow/docs notebook.ipynb
If commits are added to the pull request, synchronize your local branch: git pull origin patch-1

@pcoet
Copy link
Contributor

pcoet commented Nov 9, 2023

@Muneeb21-hub Thanks for the PR! To be honest, I prefer "indices" too, but the Google Dev Style prefers "indexes": https://developers.google.com/style/word-list#index. Let's leave this as is, since it doesn't seem to be an actual mistake.

@pcoet pcoet closed this Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants