Increase Travis coverage #78
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…urce and pre-built
See Travis' documentation: https://docs.travis-ci.com/user/languages/python/#pip Should fix: https://travis-ci.org/nbigaouette-eai/rust/jobs/212227182#L808-L814
|
Yeah, you won't be able to build from source on Travis. One of the driving reasons for getting pre-compiled binaries into the build was to make Travis useful again. It simply takes too long to build from source, and Travis times out. (Or if you run with too many parallel compilations, it'll fail with |
adamcrume
approved these changes
Mar 21, 2017
| - source travis-ci/install.sh | ||
| # Install dependencies only if we build tensorflow from source. | ||
| - if [[ "$TF_RUST_BUILD_FROM_SRC" == "true" ]]; then source travis-ci/install.sh; fi | ||
| - if [[ "$TF_RUST_BUILD_FROM_SRC" == "true" ]]; then pip install --user numpy; fi |
There was a problem hiding this comment.
Good call; we were wasting build time installing things we didn't need.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds will set Travis to follow Rust release train (stable/beta/nightly) on both Linux and OSX to increase the test platform coverage.
This should open the door to the addition of more tests, for example valgrind or sanitizers as described in #69.
Notes:
TF_RUST_BUILD_FROM_SRC=true) is explicitly disabled as I have not been able to properly do so; bazel fails withServer finished RPC without an explicit exit code(see for example here, more specifically job 14.1);env.globalinstead of explicitlyexporting them;fast_finishwill let builds decide on success or failure even if those withallow_failuresare not finished.pipinstead ofaptas it's the recommended way of doing so.