Use Epochs to load CoLA #487
Conversation
|
The kokoro failure is looking for the functions defined at the bottom of DataUtilities.swift. @BradLarson do we have a common function to use instead? |
|
Yeah I just realized that, I deleted the two files thinking they were useless now but did not try to build after, sorry about that. I can leave DatasetUtilities with them for now, there is a TODO to rely on the swift-models at some point, when it is done, this can be removed. |
Datasets/CoLA/CoLA.swift
Outdated
| public let batchSize: Int | ||
| /// The type of the collection of batches. | ||
| public typealias Batches = Slices<Sampling<Samples, ArraySlice<Int>>> | ||
| /// The type of the training seauence of epochs. |
Datasets/CoLA/CoLA.swift
Outdated
| LazyMapSequence<Batches, LabeledTextBatch>> | ||
|
|
||
| //public typealias DevDataIterator = GroupedIterator<MapIterator<ExampleIterator, DataBatch>> | ||
| //public typealias TestDataIterator = DevDataIterator |
| maxSequenceLength: maxSequenceLength, | ||
| batchSize: batchSize, | ||
| entropy: SystemRandomNumberGenerator() | ||
| ) { (example: CoLAExample) -> LabeledTextBatch in |
There was a problem hiding this comment.
What are the advantages of moving to a trailing closure?
There was a problem hiding this comment.
It's more swift-idiomatic from what Dave constantly tells me ;)
The main advantage is that you don't have to define your exampleMap function separately and pass it, you can just put in curly brackets at the end (like in the main colab example).
|
This is so helpful!! It cleans up the CoLA implementation considerably. Although there are aspects of |
|
Thanks! Hope the design review on Friday will clarify the aspects of Epochs that are unclear. |
|
Fixes #480 |
This PR changes the way CoLA is loaded to use the Epochs API.
It removes the test set (that was unused) and does the minimal amount of changes to work with the script in BertCoLA.
Two notes where the design changed:
Added functionality: we can pass a random generator and thus get reproducible results.