Adding Catalina-compatible FileHandle operations #678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #668 added an
append()method to the FileSystem protocol and an implementation in FoundationFileSystem. This implementation used FileHandle and several methods which have had their signatures change between macOS 10.15 (Catalina) and 10.16 (Big Sur). The current implementation uses the new interface, which will build with the latest Linux toolchain but will not build on the current macOS 10.15 (Catalina).This provides the older interface for use when building on macOS, and the newer one for other OS versions. Once Big Sur is the dominant build environment for macOS, we can remove this fallback.