Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#15642: Replace shapes in eltwise #15646

Merged
merged 5 commits into from
Dec 28, 2024
Merged

#15642: Replace shapes in eltwise #15646

merged 5 commits into from
Dec 28, 2024

Conversation

mouliraj-mcw
Copy link
Contributor

@mouliraj-mcw mouliraj-mcw commented Dec 3, 2024 •
edited
Loading

Ticket

Link to Github Issue #15642

What's changed

  • Replaced the usage of get_legacy_shape or get_padded_shape to padded_shape .
  • Replaced the usage of ttnn::Shape or tt::tt_metal::LegacyShape to ttnn::SimpleShape .

Checklist

@mouliraj-mcw mouliraj-mcw force-pushed the mouliraj/shape branch 2 times, most recently from 6aed054 to aff56b4 Compare December 6, 2024 09:03
@mouliraj-mcw mouliraj-mcw force-pushed the mouliraj/shape branch 4 times, most recently from f0a60a8 to 53d15d1 Compare December 12, 2024 07:09
@mouliraj-mcw mouliraj-mcw marked this pull request as ready for review December 13, 2024 04:21
@mouliraj-mcw mouliraj-mcw force-pushed the mouliraj/shape branch 2 times, most recently from 621f848 to bedf99e Compare December 17, 2024 04:30
@mouliraj-mcw mouliraj-mcw force-pushed the mouliraj/shape branch 6 times, most recently from e795422 to fdc27e5 Compare December 24, 2024 07:05
@mouliraj-mcw mouliraj-mcw merged commit 72322bd into main Dec 28, 2024
9 checks passed
@mouliraj-mcw mouliraj-mcw deleted the mouliraj/shape branch December 28, 2024 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eyonland eyonland eyonland approved these changes

@umadevimcw umadevimcw umadevimcw approved these changes

@KalaivaniMCW KalaivaniMCW Awaiting requested review from KalaivaniMCW

@patrickroberts patrickroberts Awaiting requested review from patrickroberts patrickroberts is a code owner

@yan-zaretskiy yan-zaretskiy Awaiting requested review from yan-zaretskiy yan-zaretskiy is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mouliraj-mcw @umadevimcw @eyonland