Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepend DPrint messages with device id, core coords, and RISC #15790

Merged
merged 5 commits into from
Dec 12, 2024
Merged

Prepend DPrint messages with device id, core coords, and RISC #15790

merged 5 commits into from
Dec 12, 2024

Conversation

sagarwalTT
Copy link
Contributor

@sagarwalTT sagarwalTT commented Dec 6, 2024 •
edited
Loading

Ticket

#14487

Checklist

  • Post commit CI passes
  • Blackhole Post commit (if applicable)
  • Model regression CI testing passes (if applicable)
  • Device performance regression CI testing passes (if applicable)
  • New/Existing tests provide coverage for changes

@sagarwalTT sagarwalTT changed the title Sagarwal/dprint prepend msgs Prepend DPrint messages with device id, physical core coords, and RISC Dec 6, 2024
@sagarwalTT sagarwalTT linked an issue Dec 6, 2024 that may be closed by this pull request
(optionally) tag dprint lines w/ device and core id and risc id #14487
Closed
@sagarwalTT sagarwalTT force-pushed the sagarwal/dprint_prepend_msgs branch from 6d2cdb9 to 01527d6 Compare December 6, 2024 21:56
tt-dma
tt-dma approved these changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@tt-dma tt-dma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for adding this!

@sagarwalTT sagarwalTT force-pushed the sagarwal/dprint_prepend_msgs branch 2 times, most recently from b622de5 to 63cbaf0 Compare December 12, 2024 04:31
@sagarwalTT sagarwalTT force-pushed the sagarwal/dprint_prepend_msgs branch from 6d4aa35 to be3a236 Compare December 12, 2024 15:24
@sagarwalTT sagarwalTT changed the title Prepend DPrint messages with device id, physical core coords, and RISC Prepend DPrint messages with device id, core coords, and RISC Dec 12, 2024
@sagarwalTT sagarwalTT merged commit ce20864 into main Dec 12, 2024
117 of 119 checks passed
@sagarwalTT sagarwalTT deleted the sagarwal/dprint_prepend_msgs branch December 12, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tt-dma tt-dma tt-dma approved these changes

@abhullar-tt abhullar-tt Awaiting requested review from abhullar-tt abhullar-tt is a code owner

@pgkeller pgkeller Awaiting requested review from pgkeller pgkeller is a code owner

@aliuTT aliuTT Awaiting requested review from aliuTT aliuTT is a code owner

@tt-aho tt-aho Awaiting requested review from tt-aho tt-aho is a code owner

@tt-asaigal tt-asaigal Awaiting requested review from tt-asaigal tt-asaigal is a code owner

@ubcheema ubcheema Awaiting requested review from ubcheema ubcheema is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(optionally) tag dprint lines w/ device and core id and risc id
2 participants
@sagarwalTT @tt-dma