Unvendor nlohmann json #15956
Merged
Unvendor nlohmann json #15956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blozano-tt
requested review from
ayerofieiev-tt,
dmakoviichuk-tt,
rfurko-tt,
cfjchu,
TT-BrianLiu,
razorback3,
dongjin-na,
bbradelTT,
mo-tenstorrent,
patrickroberts,
yan-zaretskiy,
eyonland,
sminakov-tt,
ubcheema,
abhullar-tt,
pgkeller,
aliuTT,
tt-aho,
tt-dma,
tt-asaigal and
a team
as code owners
tt-rkim
approved these changes
Dec 12, 2024
| @@ -4,7 +4,7 @@ | |||
|
|
|||
| #pragma once | |||
|
|
|||
| #include "tt_metal/third_party/json/json.hpp" | |||
| #include <nlohmann/json.hpp> | |||
There was a problem hiding this comment.
@patrickroberts @yan-zaretskiy
So this is our preferred way of referring to external libraries that we pull in through any dependency management system (in this case, CPM)? So it's clear it's external?
There was a problem hiding this comment.
external lib ideally you include via <>.
things from your project you include via ""
afuller-TT
reviewed
Dec 12, 2024
| @@ -18,7 +18,7 @@ | |||
| #include "impl/event/event.hpp" | |||
| #include "impl/program/program.hpp" | |||
| #include "tests/tt_metal/tt_metal/common/dispatch_fixture.hpp" | |||
| #include "third_party/json/json.hpp" | |||
| #include <nlohmann/json.hpp> | |||
afuller-TT
reviewed
Dec 12, 2024
There was a problem hiding this comment.
Wait this wasn't even a submodule? We just copy-pasted the files??
There was a problem hiding this comment.
That's what vendoring is hahaahahahahahaah
We are a funny "SW" engineering company
There was a problem hiding this comment.
I learned this term from Rayray
afuller-TT
approved these changes
Dec 12, 2024
mo-tenstorrent
approved these changes
Dec 12, 2024
ayerofieiev-tt
approved these changes
Dec 12, 2024
tt-aho
approved these changes
Dec 12, 2024
TT-billteng
approved these changes
Dec 12, 2024
|
POGGERS TY BOSS MAN |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Closes #14326
Problem description
json is an external dependency, lets treat it like one.
By having it as an external dependency, we can easily:
What's changed
Use json like external dep.
Bring it in from CPM.
Use cmake library target to propagate include path.
Checklist