-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sharded sweeps: prelu, softmax, sinh, softplus, relu_max and relu_min #16050
Open
npetrovic-tenstorrent
wants to merge
11
commits into
main
Choose a base branch
from
npetrovic/sharded-new-4
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
npetrovic-tenstorrent
requested review from
patrickroberts,
yan-zaretskiy,
eyonland,
xanderchin,
jdesousa-TT and
sjameelTT
as code owners
December 16, 2024 14:44
npetrovic-tenstorrent
changed the title
#11512: Add softmax, sinh, relu_max and relu_min
Sharded sweeps: softmax, sinh, relu_max and relu_min
Dec 16, 2024
jdesousa-TT
approved these changes
Dec 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please run the 4 new tests through the sweeps pipeline before merge.
Done |
npetrovic-tenstorrent
changed the title
Sharded sweeps: softmax, sinh, relu_max and relu_min
Sharded sweeps: prelu, softmax, sinh, relu_max and relu_min
Dec 16, 2024
npetrovic-tenstorrent
changed the title
Sharded sweeps: prelu, softmax, sinh, relu_max and relu_min
Sharded sweeps: prelu, softmax, sinh, softplus, relu_max and relu_min
Dec 17, 2024
eyonland
reviewed
Dec 31, 2024
tests/sweep_framework/sweeps/eltwise/unary/softmax/softmax_sharded.py
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#11512
Ticket
Link to Github Issue
Problem description
In sweep tests for sharded ops we add:
What's changed
Added new sweep tests
Pass rates for new sweeps:
sweeps/eltwise/unary/sinh/sinh_sharded.py
: 65 fail, 317 pass (82.98%)sweeps/eltwise/unary/softmax/softmax_sharded.py
: 382 fail, 0 pass (0%)sweeps/eltwise/unary/relu_max/relu_max_sharded.py
: 65 fail, 317 pass (82.98%)sweeps/eltwise/unary/prelu/prelu_sharded.py
: 260 fail, 1268 pass (82.98%)sweeps/eltwise/unary/relu_min/relu_min_sharded.py
: 65 fail, 317 pass (82.98%)sweeps/eltwise/unary/softplus/softplus_sharded.py
: 77 fail, 305 pass (79.84%).Checklist