Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing LegacyShape from Tensor::pad #16424

Merged
merged 7 commits into from
Jan 3, 2025
Merged

Removing LegacyShape from Tensor::pad #16424

merged 7 commits into from
Jan 3, 2025

Conversation

sminakov-tt
Copy link
Contributor

@sminakov-tt sminakov-tt commented Jan 3, 2025 •
edited
Loading

Ticket

Problem description

We need to remove Shape/LegacyShape from our codebase to completely support 0D/1D tensors
This PR is a part of the effort to fixup and merge previously reverted PR (#16222) piece by piece

What's changed

Replacing LegacyShape with SimpleShape in Tensor::pad

Checklist

jaykru-tt
jaykru-tt approved these changes Jan 3, 2025
View reviewed changes
Copy link
Contributor

@jaykru-tt jaykru-tt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@sminakov-tt sminakov-tt merged commit ca2ce56 into main Jan 3, 2025
276 of 383 checks passed
@sminakov-tt sminakov-tt deleted the sminakov/from_torch-p2 branch January 3, 2025 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaykru-tt jaykru-tt jaykru-tt approved these changes

@ayerofieiev-tt ayerofieiev-tt ayerofieiev-tt approved these changes

@ntarafdar ntarafdar Awaiting requested review from ntarafdar ntarafdar is a code owner

@sjameelTT sjameelTT Awaiting requested review from sjameelTT sjameelTT is a code owner

@yugi957 yugi957 Awaiting requested review from yugi957 yugi957 is a code owner

@jvegaTT jvegaTT Awaiting requested review from jvegaTT jvegaTT is a code owner

@llongTT llongTT Awaiting requested review from llongTT llongTT is a code owner

@nardoTT nardoTT Awaiting requested review from nardoTT nardoTT is a code owner

@cfjchu cfjchu Awaiting requested review from cfjchu cfjchu is a code owner

@dmakoviichuk-tt dmakoviichuk-tt Awaiting requested review from dmakoviichuk-tt dmakoviichuk-tt is a code owner

@TT-BrianLiu TT-BrianLiu Awaiting requested review from TT-BrianLiu TT-BrianLiu is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sminakov-tt @ayerofieiev-tt @jaykru-tt