[FABRIC] ASYNC_WR_ATOMIC_INC #17072
Merged
[FABRIC] ASYNC_WR_ATOMIC_INC #17072
+226
−83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ubcheema
approved these changes
Jan 24, 2025
aagarwalTT
force-pushed
the
aagarwal/async-wr-atomic-inc
branch
from
178a802 to
d41be5e
Compare
aliuTT
reviewed
Jan 27, 2025
| return test_buffer_handler_async_wr(); | ||
| } else if constexpr (test_command == ATOMIC_INC) { | ||
| return test_buffer_handler_atomic_inc(); | ||
| } else if constexpr (test_command == ASYNC_WR_RESP) { | ||
| return test_buffer_handler_fvcc(); | ||
| } | ||
|
|
||
| return true; |
There was a problem hiding this comment.
FYI, I fixed this for main to return false, you will see a rebase conflict here.
aliuTT
approved these changes
Jan 27, 2025
|
looks good. |
aagarwalTT
force-pushed
the
aagarwal/async-wr-atomic-inc
branch
from
d41be5e to
124680c
Compare
aagarwalTT
force-pushed
the
aagarwal/async-wr-atomic-inc
branch
from
124680c to
1b33015
Compare
afuller-TT
approved these changes
Jan 28, 2025
nhuang-tt
reviewed
Jan 29, 2025
tests/tt_metal/tt_metal/perf_microbenchmark/routing/kernels/tt_fabric_traffic_gen_tx.cpp
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Link to Github Issue
Problem description
Currently tt-fabric supports two individual commands, AsyncWrite and AtomicIncrements.
We need to implement a compound command that combines the two in one packet.
What's changed
Added support for new command, updated tests, added tests to CI
Checklist