Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for various paths #4

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

Hammster
Copy link

Hi,

I've seen that terkelg/tiny-glob#42 was blocked by a failing test, after investigating I could pinpoint it to two cases where the globalyzer could not properly parse the path

Case 1: The glob path included a ../ eg fixtures/../* which was not properly resolved
Case 2: the ./ was part of the pattern and this did not allow to simply subtract the base.length
This create the situation that ./test/*.{js,txt} was interpreted as a st/*.{js,txt}

It would be cool if this finds it's way into tiny-glob :)

Have a great day.

@Hammster
Copy link
Author

oh just saw that @lukeed did this already 😱

@terkelg
Copy link
Owner

terkelg commented Aug 1, 2019

thank you @Hammster! @lukeed looks good to you?

@lukeed
Copy link
Collaborator

lukeed commented Aug 2, 2019

Hey, haha, tbh I don't remember too much of what I did. I know that the static-versus-pattern bit got reworked. I left it as a "WIP" draft because it's breaking – tests changed.

This is a much simpler change, though I feel like posix should be avoided if possible 😬 Without going down another rabbit hole, not sure off-hand what a simpler alternative would be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants