Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I've seen that terkelg/tiny-glob#42 was blocked by a failing test, after investigating I could pinpoint it to two cases where the globalyzer could not properly parse the path
Case 1: The glob path included a
../
egfixtures/../*
which was not properly resolvedCase 2: the
./
was part of the pattern and this did not allow to simply subtract thebase.length
This create the situation that
./test/*.{js,txt}
was interpreted as ast/*.{js,txt}
It would be cool if this finds it's way into tiny-glob :)
Have a great day.