Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

addpkg(main/TG-FileStreamBot): 3.0.0 #23156

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

aicynide
Copy link
Contributor

No description provided.

@TomJo2000
Copy link
Member

TomJo2000 commented Feb 11, 2025

There doesn't seem to be a request for this package, nor any package for this project.
https://repology.org/projects/?search=TG-FileStreamBot
Those are already dealbreakers.

On top of that it should be noted that package names in Termux use exclusively lowercase letters, numbers and - so this package would need to be named tg-filestreambot for the termux package.

Copy link
Member

@TomJo2000 TomJo2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It also looks like this package compiles without patches or other build workarounds.

@TomJo2000
Copy link
Member

TomJo2000 commented Feb 11, 2025

You also haven't squashed your commits, again.
This seems to be a persistent issue with your pull requests.
I've given you the whole spiel about how to squash commits and keeping a feature branch clean on at least 3 different occasions, so I'd expect some eventual improvement in that area.

And it seems like your git config is still not set up properly as the commits are all authored by Your Name.

@aicynide
Copy link
Contributor Author

Sorry since the CI failed to build it, i didn't squashed

@TomJo2000
Copy link
Member

I might not have been as clear about this as I could have been.

Why should this be packaged in the main termux repository?
In the meantime this is gonna have to get a NACK1 from me.

Footnotes

  1. https://en.wikipedia.org/wiki/NACK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants