Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Create_service false for stand alone task on Fargate Sample #249

Merged
merged 1 commit into from
Dec 14, 2024

Conversation

CGarces
Copy link
Contributor

@CGarces CGarces commented Dec 13, 2024

Description

I think that create_service should be set to false for and standalone task (see #176).

Motivation and Context

Looks like a regression bug of #188

How Has This Been Tested?

Please note that this change not has been tested.
Is a quick fix using the GitHub web interface, feel free to close the PR and consider it as invalid.

pre-commit run -a was executed and detect changes on README,md an LICENSE by terraform_docs, looks like false positives due my environment

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@bryantbiggs bryantbiggs merged commit 803cd3b into terraform-aws-modules:master Dec 14, 2024
12 checks passed
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants