feat: Add vpc_lattice_configuration for service #250
Conversation
|
This PR has been automatically marked as stale because it has been open 30 days |
|
Any update on when this can be merged? |
modules/service/main.tf
Outdated
| @@ -188,6 +188,16 @@ resource "aws_ecs_service" "this" { | |||
| } | |||
| } | |||
|
|
|||
| dynamic "vpc_lattice_configuration" { | |||
There was a problem hiding this comment.
https://registry.terraform.io/providers/hashicorp/aws/5.84.0/docs/resources/ecs_service#vpc_lattice_configurations
This needs to be "vpc_lattice_configurations".
Can you run terraform fmt as well, please?
There was a problem hiding this comment.
Hey Damvinod, thank you for the response!
I can still see couple of issues with the module, preventing it from working. I will leave a comment on each line, explaining what needs to be done and will also mark the cosmetic changes that need to be made, for consistency.
Description
Adding
vpc_lattice_configurationoption to the service module.Motivation and Context
It adds the option to configure
vpc_lattice_configurationfor the ECS service.Breaking Changes
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request