feat: Renamed python3.8-11 to python3.12 in examples, added tag to resources #583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
antonbabenko
commented
Jun 7, 2024
antonbabenko
commented
- feat: Added terraform-aws-modules tag
- feat: Renamed python3.[8-11] => python3.12 in examples
antonbabenko
changed the title
antonbabenko
commented
Jun 7, 2024
| @@ -135,7 +135,11 @@ resource "aws_lambda_function" "this" { | |||
| } | |||
| } | |||
|
|
|||
| tags = merge(var.tags, var.function_tags) | |||
| tags = merge( | |||
There was a problem hiding this comment.
@bryantbiggs WDYT about tags? (the rest of the renaming was automatic)
There was a problem hiding this comment.
The function def, there won't be any insight into the s3 object, cloudwatch could technically be derived but ok either way. Typically, the fewer the better, and tag the main thing which other things can be derived off of that
bryantbiggs
approved these changes
Jun 7, 2024
antonbabenko
changed the title
antonbabenko
pushed a commit
that referenced
this pull request
Jun 7, 2024
## [7.5.0](v7.4.0...v7.5.0) (2024-06-07) ### Features * Renamed python3.8-11 to python3.12 in examples, added tag to resources ([#583](#583)) ([02ab668](02ab668))
|
This PR is included in version 7.5.0 🎉 |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.