Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding even more test crumbs #1473

Merged
merged 13 commits into from
Nov 14, 2023
Merged

Adding even more test crumbs #1473

merged 13 commits into from
Nov 14, 2023

Conversation

john-science
Copy link
Member

@john-science john-science commented Nov 13, 2023

What is the change?

Added test crumbs for:

  • cases
  • materials

And added impl and test crumbs for:

  • database3
  • snapshots
  • uniform mesh converter
  • axial expansion changer

Why is the change being made?

This is part of the on-going requirements work.


Checklist

  • The release notes (location doc/release/0.X.rst) are up-to-date with any important changes.
  • The documentation is still up-to-date in the doc folder.
  • No requirements were altered.
  • The dependencies are still up-to-date in pyproject.toml.

@john-science john-science added documentation Improvements or additions to documentation testing Related to tests labels Nov 13, 2023
@john-science
Copy link
Member Author

@bdlafleur @albeanth Just FYI.

@john-science john-science changed the title Adding test crumbs for cases and materials Adding even more test crumbs Nov 14, 2023
Copy link
Member

@albeanth albeanth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took a quick glance at the converters package. Just 1 edit. Thanks, @john-science!

armi/reactor/converters/axialExpansionChanger.py Outdated Show resolved Hide resolved
armi/operators/snapshots.py Outdated Show resolved Hide resolved
armi/materials/tests/test_materials.py Outdated Show resolved Hide resolved
armi/materials/tests/test_materials.py Show resolved Hide resolved
armi/materials/tests/test_materials.py Outdated Show resolved Hide resolved
armi/materials/tests/test_materials.py Outdated Show resolved Hide resolved
armi/cases/tests/test_suiteBuilder.py Outdated Show resolved Hide resolved
armi/cases/tests/test_cases.py Show resolved Hide resolved
@john-science john-science merged commit 5b3555c into main Nov 14, 2023
21 checks passed
@john-science john-science deleted the even_more_test_crumbs branch November 14, 2023 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation testing Related to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants