Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update doc build to py313 #2050

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Update doc build to py313 #2050

wants to merge 10 commits into from

Conversation

opotowsky
Copy link
Member

@opotowsky opotowsky commented Jan 10, 2025

What is the change?

The docs are being built with python 3.9. This updates them to python 3.13 (updating dependency pins in the process)

Why is the change being made?

Keepin' up with the times!


Checklist

  • The release notes have been updated if necessary.
  • The documentation is still up-to-date in the doc folder.
  • The dependencies are still up-to-date in pyproject.toml.

@opotowsky opotowsky added documentation Improvements or additions to documentation ci Related to continuous integration / github actions labels Jan 10, 2025
@opotowsky opotowsky linked an issue Jan 10, 2025 that may be closed by this pull request
Comment on lines +102 to +105
globals = {}
exec(code, globals)

if result is None:
result = globals["usermethod"]()
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm really not sure why the usermethod no longer shows up in locals.

I just tried globals on a whim and it was there. Is this dangerous?

doc/conf.py Show resolved Hide resolved
@john-science john-science marked this pull request as draft January 14, 2025 18:14
@ntouran
Copy link
Member

ntouran commented Jan 31, 2025

was just talking to @john-science about the nbextensions. That's from back when we had an awesome dockerized jupyterhub instance of ARMI with all plugins. It added a few neat tools that some users liked. It's totally fine to remove it now since we don't know of anyone using them in jupyterhub at the moment.

@john-science john-science marked this pull request as ready for review January 31, 2025 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Related to continuous integration / github actions documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update ARMI docs to Python 3.13
3 participants