Account for parent symmetry in component flux calculation #2068
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the change?
Divide by the parent block's symmetry factor when calculating the volume fraction of a component for the integrated mg flux calculation.
Why is the change being made?
When getting the integrated flux for a component, the "volume fraction" of the component is calculated. This "volume fraction" is incorrect when the component's parent block has a
symmetryFactor
that is not unity, because the componentgetVolume()
calculation does not account for the symmetry factor. To get the volume fraction correct, we have to divide by the symmetry factor.Related to #2006 , but it doesn't totally resolve it. This just addresses one symptom of the component volume not respecting the symmetry factor. This does resolve #2059 .
Checklist
doc
folder.pyproject.toml
.