Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account for parent symmetry in component flux calculation #2068

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mgjarrett
Copy link
Contributor

@mgjarrett mgjarrett commented Jan 31, 2025

What is the change?

Divide by the parent block's symmetry factor when calculating the volume fraction of a component for the integrated mg flux calculation.

Why is the change being made?

When getting the integrated flux for a component, the "volume fraction" of the component is calculated. This "volume fraction" is incorrect when the component's parent block has a symmetryFactor that is not unity, because the component getVolume() calculation does not account for the symmetry factor. To get the volume fraction correct, we have to divide by the symmetry factor.

Related to #2006 , but it doesn't totally resolve it. This just addresses one symptom of the component volume not respecting the symmetry factor. This does resolve #2059 .


Checklist

  • The release notes have been updated if necessary.
  • The documentation is still up-to-date in the doc folder.
  • The dependencies are still up-to-date in pyproject.toml.

@mgjarrett mgjarrett added the bug Something is wrong: Highest Priority label Jan 31, 2025
@mgjarrett mgjarrett self-assigned this Jan 31, 2025
@mgjarrett mgjarrett requested a review from bsculac January 31, 2025 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is wrong: Highest Priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect reaction rates reported for assemblies with symmetry factors!=1
2 participants