Merge branch 'eslint8' into next

testcafe-community · Oct 30, 2021 · 6df94fa · 6df94fa
2 parents 78e9049 + d8b836c
commit 6df94fa
Show file tree

Hide file tree

Showing 8 changed files with 649 additions and 26 deletions.
diff --git a/lib/rules/expect-expect.ts b/lib/rules/expect-expect.ts
@@ -35,7 +35,6 @@ export default createRule({
         },
         docs: {
             description: "Ensure tests have at least one expect",
-            category: "Best Practices",
             recommended: "error"
         },
         schema: []

diff --git a/lib/rules/no-debug.ts b/lib/rules/no-debug.ts
@@ -23,7 +23,6 @@ export default createRule({
         docs: {
             description:
                 "Don't allow `t.debug()` to be committed to the repository. ",
-            category: "Best Practices",
             recommended: "error"
         },
         schema: []

diff --git a/lib/rules/no-identical-title.ts b/lib/rules/no-identical-title.ts
@@ -60,7 +60,6 @@ export default createRule({
         },
         docs: {
             description: "Don't use identical titles for your tests",
-            category: "Best Practices",
             recommended: "error"
         },
         schema: []

diff --git a/lib/rules/no-only.ts b/lib/rules/no-only.ts
@@ -21,7 +21,6 @@ export default createRule({
         docs: {
             description:
                 "Don't allow `test.only` to be added to the repository",
-            category: "Best Practices",
             recommended: "error"
         },
         schema: []

diff --git a/lib/rules/no-skip.ts b/lib/rules/no-skip.ts
@@ -17,11 +17,10 @@ export default createRule({
         messages: {
             noSkip: "Do not use the `.skip` hook."
         },
-        type: "suggestion",
+        type: "problem",
         docs: {
             description:
                 "Don't allow `test.skip` or `fixture.skip` to be added to the repository",
-            category: "Best Practices",
             recommended: "warn"
         },
         schema: []

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -14,7 +14,8 @@
     "author": "Ben Monro <[email protected]>",
     "contributors": [
         "Mikhail Losev <[email protected]>",
-        "codejedi365 <[email protected]>"
+        "codejedi365 <[email protected]>",
+        "Matthias Klass <[email protected]>"
     ],
     "license": "MIT",
     "bugs": {
@@ -51,7 +52,7 @@
         "@types/semver": "^7.3.9",
         "@typescript-eslint/eslint-plugin": "^4.32.0",
         "@typescript-eslint/parser": "^4.32.0",
-        "@typescript-eslint/types": "^4.32.0",
+        "@typescript-eslint/types": "^5.2.0",
         "eslint": "^7.32.0",
         "eslint-config-airbnb-base": "^14.2.1",
         "eslint-config-airbnb-typescript": "^14.0.0",
@@ -79,10 +80,10 @@
         "typescript": "^4.4.3"
     },
     "dependencies": {
-        "@typescript-eslint/experimental-utils": "^4.32.0"
+        "@typescript-eslint/experimental-utils": "^5.2.0"
     },
     "peerDependencies": {
-        "eslint": "^7.0.0"
+        "eslint": "^7.0.0 || ^8.0.0"
     },
     "engines": {
         "node": ">=10.24"

diff --git a/tests/lib/index.test.ts b/tests/lib/index.test.ts
@@ -38,7 +38,6 @@ describe("Rule Definitions", () => {
             const rule = rulebook.rules[ruleName];
             expect(rule).toHaveProperty("create", expect.any(Function));
             expect(rule.meta.docs?.url).not.toBeEmpty();
-            expect(rule.meta.docs?.category).toBe("Best Practices");
             expect(rule.meta.docs?.description).not.toBeEmpty();
         }
     );