fix: test coverage by modifying implementation

testcafe-community · Oct 4, 2021 · 7abf140 · 7abf140
1 parent 6dd4737
commit 7abf140
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 21 deletions.
diff --git a/lib/index.ts b/lib/index.ts
@@ -2,7 +2,7 @@
 // Plugin Definition
 //------------------------------------------------------------------------------
 
-import {
+import type {
     RuleListener,
     RuleMetaDataDocs,
     RuleModule

diff --git a/lib/rules/no-debug.ts b/lib/rules/no-debug.ts
@@ -4,22 +4,10 @@
  */
 import type {
     CallExpression,
-    LeftHandSideExpression,
-    MemberExpression,
-    MetaProperty
+    MemberExpression
 } from "@typescript-eslint/types/dist/ast-spec";
-import { AST_NODE_TYPES } from "@typescript-eslint/experimental-utils";
 import { createRule } from "../create-rule";
 
-function hasPropertyAttr(
-    callee: LeftHandSideExpression
-): callee is MemberExpression | MetaProperty {
-    return (
-        callee.type === AST_NODE_TYPES.MemberExpression ||
-        callee.type === AST_NODE_TYPES.MetaProperty
-    );
-}
-
 //------------------------------------------------------------------------------
 // Rule Definition
 //------------------------------------------------------------------------------
@@ -44,14 +32,12 @@ export default createRule({
     create(context) {
         return {
             "CallExpression[callee.property.name='debug']": (
-                node: CallExpression
+                node: CallExpression & { callee: MemberExpression }
             ) => {
-                if (hasPropertyAttr(node.callee)) {
-                    context.report({
-                        node: node.callee.property,
-                        messageId: "noDebugMessage"
-                    });
-                }
+                context.report({
+                    node: node.callee.property,
+                    messageId: "noDebugMessage"
+                });
             }
         };
     }

diff --git a/tests/lib/index.ts b/tests/lib/index.ts
@@ -21,3 +21,7 @@ it("should have a recommended config with recommended rules", () => {
         "testcafe-community/noSkip": "warn"
     });
 });
+
+// it("should handle a config generation if a rule's RuleMetaDocs is obmitted", () => {
+//     //
+// });
-Original file line number
+Diff line change
@@ Expand Up @@
             "testcafe-community/noSkip": "warn"
         });
     });
+    // it("should handle a config generation if a rule's RuleMetaDocs is obmitted", () => {
+    //     //
+    // });