Actually map exposed ports for HTTP client #531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @thomaseizinger , if you have a free moment, could you let me know if this is a change that might be useful for the experimental client? Many thanks! |
thomaseizinger
changed the title
|
Thanks! Can you deal with the CI failures please? |
|
Still some failures unfortunately. |
Chrisss93
force-pushed
the
more-bollard
branch
from
f4c26f1 to
189c4cd
Compare
Chrisss93
force-pushed
the
more-bollard
branch
from
189c4cd to
44ccfc2
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When switching from the Cli client to the Http client I noticed that the expose_ports of my Image were no longer dynamically mapping to free ports on the docker daemon's host. It seems like this is a gap to fill as a user might want a specific container port (that the image manifest may or may not have an EXPOSE layer for) mapped to a free port on the daemon host.