Skip to content

Commit

Permalink
some forgotten update
Browse files Browse the repository at this point in the history
  • Loading branch information
teuben committed Sep 6, 2023
1 parent bf89359 commit ffb3bac
Showing 1 changed file with 13 additions and 11 deletions.
24 changes: 13 additions & 11 deletions TODO.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,31 +2,35 @@

- python vs. python3 (just a worry if some have no python, but do have python3)

- pythana (as package name) is already in use by PyPi: https://pypi.org/project/pythena/
so either we change the name, or live with duplicate. Plenty of those for NEMO already.

Also: if we allow 'pip install' we need to build a proper wheel, such that athenak gets
pulled and compiled.


- for output (run) directory, use basename of the problem set, and then run1, run2, ..... inside of those?
- the startup tool could look inside the problem run directories
- this closes the loop in running and reviewing old runs
- could clean up after running?

- GUI peculiarities
- when browsing, a cancel does not repopulate with the old entry
- when browsing, a cancel does not repopulate with the old entry [fixed]
- killing parent will not kill the children (could be an advanced option,
because it's nice killing a parent keeps the children alive.
- resizing and sizing of sub-areas in the GUI (avoid negative space)
- the delay(ms) in the animator doesn't seem to work well, it's erratic?
For example I had it taking 5.8sec to do run2, but that was then
independent of the delay setting , which is now 1..20 ms.
- in the animation, the picture at T=0 when nothing is loaded yet looks
- it's easy to accidentally hiut the RUN button twice.... athena will run twice. Do
- it's easy to accidentally hut the RUN button twice.... athena will run twice. Do
we need to make a lock file?

- Important need for our GUI tags. We need a new TAGNAME, that clones a keyword value, e.g.
nx=1 # help for a #> SLIDER 0:10:1
ny=1 # help for b #> LINK nx
or in athena there are blocks, so there it would need to be something like
ny=1 # help for b #> LINK mesh/nx
this would cause mesh/ny to get the value of mesh/nx.

- GUI ideas
- when in animation and changing variables, perhaps stick to the time so one can flip at that time
between e.g. x1v-dens and x1v-velx
- when in a zoomed mode, remember the new viewing frame and keep that as the animation continues
or flipping between line and dots, or flipping between variables?

- option to integrate with a running athena [advanced]

Expand All @@ -37,8 +41,6 @@
- plot2d: allow option of contour with color, or just contour or just color. this would
(like in plot1d) give us option to combine two variables and compare them.

- plot2d: can we assume nx3=1 or could we also have X or Y slices? [done, indeed we assume Z=0]

- ensure if with id= we can handle different *.tab files. Probably need a new --id flag in plot1d.py for this
In the end, extracting them from the bin file might be faster.

Expand Down

0 comments on commit ffb3bac

Please sign in to comment.