Skip to content

More tests #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 25, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions typescript/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -274,11 +274,12 @@ b7b30c1 : Make more typesafe
You can choose a different version from the list or create new one. But bumpp is smart enough to use appropriate next version.

3. Verify and confirm
4. Push commit and tag
4. Push commit and tag

```
git push --follow-tags
```

5. The new tag will trigger a release on github actions.
6. Go to github and create release using the new tag. Make sure you set the correct previous tag prefixed with `typescript-v`

Expand Down Expand Up @@ -317,6 +318,7 @@ git push --follow-tags
- [ ] validate page prop somehow. not clear how to do yet. we can't use the /schema because it's HUGE and also because it's outside of /typescript. Will need to think about this.

maybe do something like this?

```
import type { Page } from "../models/generated/page/page";
import { isPage } from "../models/generated/essential-types";
Expand Down Expand Up @@ -353,4 +355,4 @@ export function validatePageWithError(obj: unknown): {

will require us to write a validator and we won't benefit from the defined schema jsons.

- [ ] make error boundary catch errors in JsonDocRenderer.tsx body
- [ ] make error boundary catch errors in JsonDocRenderer.tsx body
8 changes: 5 additions & 3 deletions typescript/eslint.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,11 @@ module.exports = [
// "@typescript-eslint/no-explicit-any": "error",
"@typescript-eslint/no-unused-vars": [
"warn",
{ argsIgnorePattern: "^_" },
{
argsIgnorePattern: "^_",
varsIgnorePattern: "^_",
caughtErrorsIgnorePattern: "^_",
},
],

// React rules
Expand Down Expand Up @@ -97,9 +101,7 @@ module.exports = [
"coverage/**",
".jest/**",
"scripts/**",
"tests/**",
"**/generated/**",
"src/serialization/**",
],
},
];
224 changes: 224 additions & 0 deletions typescript/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 4 additions & 3 deletions typescript/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,9 @@
"clean": "rm -rf dist",
"build": "tsup",
"build:watch": "tsup --watch",
"dev": "concurrently \"npm run build:watch\" \"npm run lint:watch\" \"npm run type-check:watch\"",
"type-check:watch": "tsc --noEmit --watch --pretty",
"lint:watch": "eslint src --ext .ts,.tsx --cache",
"dev": "concurrently \"npm run build:watch\" \"npm run lint:watch\" \"npm run check:watch\"",
"check:watch": "tsc --noEmit --watch --pretty",
"lint:watch": "nodemon --watch src --ext ts,tsx --exec \"eslint src --ext .ts,.tsx\"",
"generate-types": "ts-node scripts/generate-types.ts",
"test": "vitest",
"test:run": "vitest run",
Expand Down Expand Up @@ -62,6 +62,7 @@
"json-schema-to-typescript": "^15.0.4",
"json5": "^2.2.3",
"lint-staged": "^15.5.2",
"nodemon": "^3.1.10",
"prettier": "3.5.3",
"puppeteer": "^24.9.0",
"size-limit": "^11.2.0",
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import type { Block } from "../../block";
import type { BlockBase } from "../../base";

export type EquationBlock = Block & {
export type EquationBlock = BlockBase & {
type: "equation";
equation: {
expression: string;
Expand Down
Loading
Loading