Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #49 #53

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix #49 #53

wants to merge 2 commits into from

Conversation

dcferreira
Copy link

This was removed in a previous commit, but it breaks urls for some reason, as described in #49.
I just restored this line from cdc675b, where it was still working

@dcferreira
Copy link
Author

Test still fails, but somehow seems to be in a non-related part of the code? Not sure what to think of this.

Either way I think a check is missing in reverse_url@statik/views.py, about whether the path is a file or a directory. I did a dirty fix in that it just checks for "*.js", and the data-simple example renders correctly. Obviously, all other file extensions are missing.

@thanethomson
Copy link
Owner

Thanks for the PR! Let's get the tests passing though 😁 I'll investigate too.

@dcferreira
Copy link
Author

I'm extra confused here because the following command:
git clone https://github.com/thanethomson/statik.git statik_tmp && cd statik_tmp && python -m unittest discover
fails with the same error that travis throws now (even though the latest commit in master passed the tests, according to travis).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants