Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add margin to sign in name and sign out button #88

Closed
wants to merge 1 commit into from

Conversation

amandaguan-ag
Copy link
Collaborator

@amandaguan-ag amandaguan-ag commented Apr 6, 2024

Type of Changes

Type
✨ UI Design
🔗 Update dependencies

Acceptance Criteria

  • UI improvement for better visual separation between user's display name and sign-out button.
  • Ensure consistent margin in both desktop and mobile views.
  • Maintain responsive design with the new margin addition.

Description

This PR addresses the UI enhancement for the navigation bar by providing adequate margin between the "Signed in as [User Name]" and the "Sign Out" button. Previously, the elements were visually touching each other, especially on smaller screens, creating a cramped look and feel. With this update, we wrap the Typography and SignOutButton in separate Box components to individually control their styles, ensuring a better user experience across all devices.

Updates

Before

image

After

image

Testing Steps / QA Criteria

  • Pull down this branch with git pull origin ag-sign-out-margin and check out the branch with git checkout ag-sign-out-margin.
  • Run npm start to launch the app.
  • Verify that there is now a margin between the "Signed in as [User Name]" and the "Sign Out" button on both desktop and mobile views.
  • Resize the browser window to ensure that the margin remains consistent across various screen sizes.

@amandaguan-ag amandaguan-ag self-assigned this Apr 6, 2024
@MiliMade
Copy link
Collaborator

MiliMade commented Apr 6, 2024

Hey @amandaguan-ag there's a PR open which addresses the nav bar design

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants