Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ar add item to list issue 20 #39

Merged
merged 2 commits into from
Sep 29, 2024
Merged

Ar add item to list issue 20 #39

merged 2 commits into from
Sep 29, 2024

Conversation

arandel1
Copy link
Collaborator

Description

  • User can now add an item directly from the list page instead of navigating to the Manage List page.
  • When a user clicks "Add Item" button, the user is navigated to the pre-existing Manage List component (/manage-list url)
  • After a user is taken to the Add Item component and submits a new item, if the item is successfully added, the user is navigated back to /list.

Related Issue

closes 20

Acceptance Criteria

  • User is given an option to add an item directly from their list.
  • User can input the name of an item
  • User can select when they will need that item again from a dropdown menu of Soon, Kind of Soon, Not soon
  • When a user clicks Submit, the item is added to their list.

Type of Changes

enhancement

Updates

Before

Screen Shot 2024-09-24 at 11 56 01 AM
  • No add item button

After

Screen Shot 2024-09-24 at 11 56 21 AM
  • Add Item button

Testing Steps / QA Criteria

  • Pull from branch: ar-add-item-to-list-issue-20
  • Sign in and select a list
  • Navigate to List page
  • Click Add Item button
  • You will be taken to /manage-list (see url change)
  • Add an item, click Submit
  • If your item was successfully added, you will be taken back to List page. If your item is not successfully added, you will stay on the Manage List page.

Copy link

Visit the preview URL for this PR (updated for commit 46b5196):

https://tcl-76-smart-shopping-list--pr39-ar-add-item-to-list-2sh1gfq2.web.app

(expires Tue, 01 Oct 2024 17:03:26 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 512b1a88be8ae05fd3e727b99332819df760271d

Copy link
Collaborator

@sar-mko sar-mko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great! Nice job.

Copy link
Collaborator

@EmmaBin EmmaBin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works very well!

Copy link
Collaborator

@MarcosPerez16 MarcosPerez16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing went well and everything is working accordingly.

@arandel1 arandel1 merged commit 695a2d3 into main Sep 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants