SL-150 #3130
SL-150 #3130
Conversation
There was a problem hiding this comment.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
phpcs
[phpcs] reported by reviewdog 🐶NormalizedArrays.Arrays.CommaAfterLast.MissingMultiLine
There should be a comma after the last array item in a multi-line array.
[phpcs] reported by reviewdog 🐶SlevomatCodingStandard.Arrays.TrailingArrayComma.MissingTrailingComma
Multi-line arrays must have a trailing comma after the last element.
There was a problem hiding this comment.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
phpcs
[phpcs] reported by reviewdog 🐶Generic.WhiteSpace.DisallowSpaceIndent.SpacesUsed
Tabs must be used to indent lines; spaces are not allowed
[phpcs] reported by reviewdog 🐶NormalizedArrays.Arrays.CommaAfterLast.MissingMultiLine
There should be a comma after the last array item in a multi-line array.
[phpcs] reported by reviewdog 🐶SlevomatCodingStandard.Arrays.TrailingArrayComma.MissingTrailingComma
Multi-line arrays must have a trailing comma after the last element.
[phpcs] reported by reviewdog 🐶WordPress.PHP.YodaConditions.NotYoda
Use Yoda Condition checks, you must.
[phpcs] reported by reviewdog 🐶NormalizedArrays.Arrays.CommaAfterLast.MissingMultiLine
There should be a comma after the last array item in a multi-line array.
[phpcs] reported by reviewdog 🐶SlevomatCodingStandard.Arrays.TrailingArrayComma.MissingTrailingComma
Multi-line arrays must have a trailing comma after the last element.
[phpcs] reported by reviewdog 🐶NormalizedArrays.Arrays.CommaAfterLast.MissingMultiLine
There should be a comma after the last array item in a multi-line array.
[phpcs] reported by reviewdog 🐶SlevomatCodingStandard.Arrays.TrailingArrayComma.MissingTrailingComma
Multi-line arrays must have a trailing comma after the last element.
[phpcs] reported by reviewdog 🐶Generic.Formatting.MultipleStatementAlignment.NotSameWarning
Equals sign not aligned with surrounding assignments; expected 4 spaces but found 1 space
[phpcs] reported by reviewdog 🐶NormalizedArrays.Arrays.CommaAfterLast.MissingMultiLine
There should be a comma after the last array item in a multi-line array.
[phpcs] reported by reviewdog 🐶SlevomatCodingStandard.Arrays.TrailingArrayComma.MissingTrailingComma
Multi-line arrays must have a trailing comma after the last element.
[phpcs] reported by reviewdog 🐶NormalizedArrays.Arrays.CommaAfterLast.MissingMultiLine
There should be a comma after the last array item in a multi-line array.
[phpcs] reported by reviewdog 🐶SlevomatCodingStandard.Arrays.TrailingArrayComma.MissingTrailingComma
Multi-line arrays must have a trailing comma after the last element.
[phpcs] reported by reviewdog 🐶Generic.WhiteSpace.DisallowSpaceIndent.SpacesUsed
Tabs must be used to indent lines; spaces are not allowed
[phpcs] reported by reviewdog 🐶Squiz.Commenting.FunctionComment.Missing
Missing doc comment for function __construct()
[phpcs] reported by reviewdog 🐶Universal.WhiteSpace.PrecisionAlignment.Found
Found precision alignment of 3 spaces.
[phpcs] reported by reviewdog 🐶Generic.WhiteSpace.DisallowSpaceIndent.SpacesUsed
Tabs must be used to indent lines; spaces are not allowed
[phpcs] reported by reviewdog 🐶Universal.Operators.DisallowStandalonePostIncrementDecrement.PostIncrementFound
Stand-alone post-increment statement found. Use pre-increment instead: ++$total_updated .
[phpcs] reported by reviewdog 🐶Generic.WhiteSpace.IncrementDecrementSpacing.SpaceAfterIncrement
Expected no spaces between $total_updated and the increment operator; 1 found
[phpcs] reported by reviewdog 🐶NormalizedArrays.Arrays.CommaAfterLast.FoundSingleLine
A comma after the last array item in a single-line array is not allowed.
[phpcs] reported by reviewdog 🐶NormalizedArrays.Arrays.CommaAfterLast.FoundSingleLine
A comma after the last array item in a single-line array is not allowed.
[phpcs] reported by reviewdog 🐶NormalizedArrays.Arrays.CommaAfterLast.FoundSingleLine
A comma after the last array item in a single-line array is not allowed.
[phpcs] reported by reviewdog 🐶NormalizedArrays.Arrays.CommaAfterLast.FoundSingleLine
A comma after the last array item in a single-line array is not allowed.
[phpcs] reported by reviewdog 🐶Squiz.Classes.SelfMemberReference.NotUsed
Must use "self::" for local static member reference
[phpcs] reported by reviewdog 🐶Generic.WhiteSpace.DisallowSpaceIndent.SpacesUsed
Tabs must be used to indent lines; spaces are not allowed
[phpcs] reported by reviewdog 🐶Universal.Operators.DisallowStandalonePostIncrementDecrement.PostIncrementFound
Stand-alone post-increment statement found. Use pre-increment instead: ++$total_updated .
[phpcs] reported by reviewdog 🐶Generic.WhiteSpace.IncrementDecrementSpacing.SpaceAfterIncrement
Expected no spaces between $total_updated and the increment operator; 1 found
[phpcs] reported by reviewdog 🐶Squiz.Strings.DoubleQuoteUsage.NotRequired
String "UPDATE %i SET name = %s, seats = %d WHERE id = %s" does not require double quotes; use single quotes instead
[phpcs] reported by reviewdog 🐶WordPress.PHP.YodaConditions.NotYoda
Use Yoda Condition checks, you must.
[phpcs] reported by reviewdog 🐶WordPress.WhiteSpace.ControlStructureSpacing.NoSpaceAfterStructureOpen
Space after opening control structure is required
[phpcs] reported by reviewdog 🐶WordPress.WhiteSpace.ControlStructureSpacing.NoSpaceBeforeOpenParenthesis
No space before opening parenthesis is prohibited
[phpcs] reported by reviewdog 🐶Squiz.ControlStructures.ControlSignature.SpaceAfterKeyword
Expected 1 space after IF keyword; 0 found
[phpcs] reported by reviewdog 🐶Universal.Operators.DisallowStandalonePostIncrementDecrement.PostIncrementFound
Stand-alone post-increment statement found. Use pre-increment instead: ++$total_updated .
[phpcs] reported by reviewdog 🐶Generic.WhiteSpace.IncrementDecrementSpacing.SpaceAfterIncrement
Expected no spaces between $total_updated and the increment operator; 1 found
There was a problem hiding this comment.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
phpcs
[phpcs] reported by reviewdog 🐶Universal.WhiteSpace.PrecisionAlignment.Found
Found precision alignment of 3 spaces.
[phpcs] reported by reviewdog 🐶Generic.WhiteSpace.DisallowSpaceIndent.SpacesUsed
Tabs must be used to indent lines; spaces are not allowed
[phpcs] reported by reviewdog 🐶Universal.Operators.DisallowStandalonePostIncrementDecrement.PostIncrementFound
Stand-alone post-increment statement found. Use pre-increment instead: ++$total_updated .
[phpcs] reported by reviewdog 🐶Generic.WhiteSpace.IncrementDecrementSpacing.SpaceAfterIncrement
Expected no spaces between $total_updated and the increment operator; 1 found
[phpcs] reported by reviewdog 🐶NormalizedArrays.Arrays.CommaAfterLast.FoundSingleLine
A comma after the last array item in a single-line array is not allowed.
[phpcs] reported by reviewdog 🐶NormalizedArrays.Arrays.CommaAfterLast.FoundSingleLine
A comma after the last array item in a single-line array is not allowed.
[phpcs] reported by reviewdog 🐶NormalizedArrays.Arrays.CommaAfterLast.FoundSingleLine
A comma after the last array item in a single-line array is not allowed.
[phpcs] reported by reviewdog 🐶NormalizedArrays.Arrays.CommaAfterLast.FoundSingleLine
A comma after the last array item in a single-line array is not allowed.
[phpcs] reported by reviewdog 🐶Generic.WhiteSpace.DisallowSpaceIndent.SpacesUsed
Tabs must be used to indent lines; spaces are not allowed
[phpcs] reported by reviewdog 🐶Universal.Operators.DisallowStandalonePostIncrementDecrement.PostIncrementFound
Stand-alone post-increment statement found. Use pre-increment instead: ++$total_updated .
[phpcs] reported by reviewdog 🐶Generic.WhiteSpace.IncrementDecrementSpacing.SpaceAfterIncrement
Expected no spaces between $total_updated and the increment operator; 1 found
[phpcs] reported by reviewdog 🐶Squiz.Strings.DoubleQuoteUsage.NotRequired
String "UPDATE %i SET name = %s, seats = %d WHERE id = %s" does not require double quotes; use single quotes instead
[phpcs] reported by reviewdog 🐶WordPress.PHP.YodaConditions.NotYoda
Use Yoda Condition checks, you must.
[phpcs] reported by reviewdog 🐶WordPress.WhiteSpace.ControlStructureSpacing.NoSpaceAfterStructureOpen
Space after opening control structure is required
[phpcs] reported by reviewdog 🐶WordPress.WhiteSpace.ControlStructureSpacing.NoSpaceBeforeOpenParenthesis
No space before opening parenthesis is prohibited
[phpcs] reported by reviewdog 🐶Squiz.ControlStructures.ControlSignature.SpaceAfterKeyword
Expected 1 space after IF keyword; 0 found
[phpcs] reported by reviewdog 🐶Universal.Operators.DisallowStandalonePostIncrementDecrement.PostIncrementFound
Stand-alone post-increment statement found. Use pre-increment instead: ++$total_updated .
[phpcs] reported by reviewdog 🐶Generic.WhiteSpace.IncrementDecrementSpacing.SpaceAfterIncrement
Expected no spaces between $total_updated and the increment operator; 1 found
rafsuntaskin
added
the
needs artifact
lucatume
removed
the
needs artifact
|
|
||
| $total_updated = 0; | ||
|
|
||
| $ticketable_post_types = (array) tribe_get_option( 'ticket-enabled-post-types', [] ); |
There was a problem hiding this comment.
Let's use this maybe:
event-tickets/src/Tribe/Main.php
Line 1044 in a968f03
Co-authored-by: Rafsun Chowdhury <[email protected]>
| */ | ||
| export async function handleReservationsUpdatedFollowingSeatTypes(updated) { | ||
| if (!updated || Object.keys(updated).length === 0) { | ||
| return 0; |
There was a problem hiding this comment.
| return 0; | |
| return false; |
Ticket: SL-150
Related PR on service
This PR udpates the code to handle the seat type and reservation updates following a layout edit operation.
Demos: