Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SL-205] Feat - Add support for ticket purchase limit filter with Seating ticket form. #3438

Merged
merged 13 commits into from
Dec 4, 2024

Conversation

rafsuntaskin
Copy link
Contributor

@rafsuntaskin rafsuntaskin commented Dec 3, 2024

🎫 Ticket

SL-205

🗒️ Description

🎥 Artifacts

🎥 screencast(s): https://share.cleanshot.com/YZRZ2q2m

✔️ Checklist

  • Ran npm run changelog to add changelog file(s). More info here
  • Code is covered by NEW wpunit or integration tests.
  • Code is covered by EXISTING wpunit or integration tests.
  • Are all the required tests passing?
  • Automated code review comments are addressed.
  • Have you added Artifacts?
  • Check the base branch for your PR.
  • Add your PR to the project board for the release.

@rafsuntaskin rafsuntaskin self-assigned this Dec 4, 2024
@rafsuntaskin rafsuntaskin marked this pull request as ready for review December 4, 2024 15:24
Copy link
Contributor

@lucatume lucatume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic looks ok, but it's missing a JS test for the tickets block and the notice.

Copy link
Contributor

@lucatume lucatume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The request for tests does not make sense in this context since the value is merely passed to the service.

@rafsuntaskin rafsuntaskin merged commit 3449988 into release/T24.hydra Dec 4, 2024
20 of 21 checks passed
@rafsuntaskin rafsuntaskin deleted the feat/sl-205-purchase-limit branch December 4, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants