-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
React 18 compatibility: Version 4.0.0 #76
Open
bordoni
wants to merge
12
commits into
main
Choose a base branch
from
fix/TEC-5322-wp-67-packages
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
bordoni
commented
Nov 14, 2024
•
edited by lucatume
Loading
edited by lucatume
- The Events Calendar -- React 18 compatibility the-events-calendar#4811
- Events Pro -- https://github.com/the-events-calendar/events-pro/pull/2618
- Common -- React 18 compatibility tribe-common#2268
- Event Ticket -- React 18 compatibility event-tickets#3424
- Event Tickets Plus -- https://github.com/the-events-calendar/event-tickets-plus/pull/1696
Camwyn
reviewed
Dec 3, 2024
'last 1 ChromeAndroid version', | ||
'last 1 FirefoxAndroid version', | ||
'> 1%, not op_mini all, not ie <= 11, not ie_mob <= 11', | ||
">0.2%", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That seems...small
Why drop from 1%
to 0.2%
?
lucatume
force-pushed
the
fix/TEC-5322-wp-67-packages
branch
from
December 4, 2024 14:53
430c5e8
to
4f3211c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.