Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Set compilers in presets" #155

Closed
wants to merge 1 commit into from

Conversation

stevenbrix
Copy link
Collaborator

Reverts #151

This breaks local developer workflows in swift/winrt since it forces swiftwinrt.exe to build using clang when you want to debug using LLDB, which it can't do. reverting seems to work fine locally, sending up this PR to see if it passes CI

@stevenbrix stevenbrix requested a review from a team as a code owner April 8, 2024 21:09
Copy link
Contributor

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not just pass -gcodeview then? clang and WinDBG are compatible as are clang and lldb. This is restoring undefined behaviour in CMake, and I would rather that we fix forward rather than revert here.

@stevenbrix
Copy link
Collaborator Author

@compnerd i think #156 is a better fix, will close this one

@stevenbrix stevenbrix closed this Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants