Handle FuncCall nodes that represent first class callables #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbrekelmans
approved these changes
Nov 23, 2024
spawnia
force-pushed
the
handle-potential-first-class-callable
branch
from
33e3983
to
abaeae5
Compare
|
@dbrekelmans I rebased atop the latest changes. I think #33 and this can be applied independently from one another. The condition I put to check for first class callables should come before the condition added there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stumbled upon this while working on a fix for #31. The original fix no longer applies, but I think this is still valuable to ensure PHP 8.1 compatibility.