Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check all certificates in bundle for sha1 signed certificate #966

Merged
merged 1 commit into from
Dec 16, 2024
Merged

Check all certificates in bundle for sha1 signed certificate #966

merged 1 commit into from
Dec 16, 2024

Conversation

ehelms
Copy link
Member

@ehelms ehelms commented Dec 13, 2024

Refs c9e090a

@ehelms
Copy link
Member Author

ehelms commented Dec 13, 2024

Now I see theforeman/smart-proxy#874 (comment) so this won't work :/

@ehelms ehelms force-pushed the check-all-certs branch 2 times, most recently from f4108c3 to 30d7b8a Compare December 16, 2024 13:56
ekohl
ekohl approved these changes Dec 16, 2024
View reviewed changes
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good to me.

definitions/checks/check_sha1_certificate_authority.rb Outdated Show resolved Hide resolved
@ekohl ekohl merged commit be2304c into theforeman:master Dec 16, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekohl ekohl ekohl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ehelms @ekohl