Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix installation of non-develop katello-devel box #1708

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

m-bucher
Copy link
Contributor

The example probably does not work, since the mentioned fix to puppet-katello_devel is probably not available in the yum-repositories.

Requires theforeman/puppet-katello_devel@e276ccb

@m-bucher m-bucher force-pushed the fix_non-develop_branch branch from dc5ef42 to 72edf9e Compare October 2, 2023 13:13
@m-bucher m-bucher force-pushed the fix_non-develop_branch branch from 72edf9e to 3b1a619 Compare October 25, 2023 09:56
@m-bucher m-bucher force-pushed the fix_non-develop_branch branch from 3b1a619 to b375a39 Compare January 10, 2024 11:02
@m-bucher m-bucher force-pushed the fix_non-develop_branch branch from b375a39 to 6f0f931 Compare February 1, 2024 09:59
@m-bucher m-bucher force-pushed the fix_non-develop_branch branch from 6f0f931 to 7fd8004 Compare July 25, 2024 09:34
@m-bucher m-bucher marked this pull request as ready for review July 25, 2024 09:35
@m-bucher m-bucher force-pushed the fix_non-develop_branch branch from 7fd8004 to 543e287 Compare July 26, 2024 15:20
Comment on lines 21 to 22
- "--katello-devel-extra-plugins theforeman/foreman_rh_cloud"
- "--katello-devel-extra-plugins theforeman/foreman_virt_who_configure"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really always need this? This breaks the installation of a non-nightly version, because it always takes the latest version.
If we want to always install this (without making it optional), this would also need a possibility to configure the specific SCM-version.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably also a question for @chris1984 , because you added this in #1783

I would rather have it in centos9-katello-devel sample definition (see diff), so one can opt-out 😁 .

Copy link
Member

@chris1984 chris1984 Nov 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am fine with that, we just added it since we were doing a lot of work with virt-who at the time and also now doing work with rh_cloud. Feel free to move it out @m-bucher where it can be opt-out if needed.

@m-bucher m-bucher force-pushed the fix_non-develop_branch branch from 543e287 to 44e16f2 Compare November 13, 2024 09:40
@m-bucher m-bucher requested a review from ekohl November 13, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants