Associate more templates with CentOS Stream #1885
Merged
+11
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamruzicka
force-pushed
the
stream-templates
branch
2 times, most recently
from
3e5bc56 to
e83d073
Compare
adamruzicka
force-pushed
the
stream-templates
branch
from
e83d073 to
eb85375
Compare
evgeni
approved these changes
Dec 3, 2024
ekohl
approved these changes
Dec 3, 2024
ekohl
reviewed
Dec 3, 2024
| ptables: | ||
| - Kickstart default | ||
| state: present | ||
| password_hash: "SHA256" |
There was a problem hiding this comment.
We made this the default, but I don't mind making it explicit now because we didn't add a migration to change existing OSes.
There was a problem hiding this comment.
Ah yes, probably Adam didn't have theforeman/foreman-ansible-modules#1779 in his setup :)
There was a problem hiding this comment.
I indeed did not have that
There was a problem hiding this comment.
Heh, I recall fixing that after Archana run into the same thing when initially writing this play.
There was a problem hiding this comment.
Funny, I thought it was related to theforeman/foreman@e2dee7d but now that I read the PR itself it should really be the more secure SHA512.
Suggested change
| password_hash: "SHA256" | |
| password_hash: "SHA512" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup on #1856