Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Abstract string functions to support both mbstring and native #39

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Abstract string functions to support both mbstring and native #39

wants to merge 1 commit into from

Conversation

wyrfel
Copy link
Contributor

@wyrfel wyrfel commented Dec 12, 2019

No description provided.

@wyrfel wyrfel mentioned this pull request Dec 12, 2019
Closed
@wyrfel wyrfel force-pushed the feature/string-functions branch from 9b4993a to 81d3028 Compare December 12, 2019 12:58
@wyrfel wyrfel self-assigned this Dec 15, 2019
@wyrfel wyrfel force-pushed the feature/string-functions branch from 81d3028 to 14c9327 Compare December 15, 2019 18:06
@coveralls
Copy link

Coverage Status

Coverage decreased (-4.2%) to 95.756% when pulling 14c9327 on feature/string-functions into 9a54a71 on master.

@ejegg
Copy link

ejegg commented Oct 21, 2022

I'd really like to see this fixed - we've started using the library at the Wikimedia Foundation for parsing donor names, and Irish donors who write their name 'Someone Ó Something' are coming out with broken unicode.
wyrfel do you want to pick this back up? If you don't have time right now, I'd be happy to make my own fork and add the required test coverage on top of this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@wyrfel wyrfel

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wyrfel @coveralls @ejegg