-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TEST][DNM] make 3 components modular #9296
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Under windows the Python interpreter has to be called explicitly. Without it an attempt to execute a Python script fails silently. Signed-off-by: Guennadi Liakhovetski <[email protected]>
When ipc4_get_drv() fails to find a driver, it might mean, that the driver needs to be linked dynamically. Printing an error in such a case wrongly fails CI testing. Signed-off-by: Guennadi Liakhovetski <[email protected]>
Use consistent TABs and spaces in src/samples/audio/Kconfig Signed-off-by: Guennadi Liakhovetski <[email protected]>
Maximum instance count cannot be zero, they have to be supplied by respective modules. Signed-off-by: Guennadi Liakhovetski <[email protected]>
Use maximum instance count from modules when building a manifest. Signed-off-by: Guennadi Liakhovetski <[email protected]>
When pipelines are destroyed, component drivers' .reset() and .free() are called. If those drivers were loaded dynamically their memory is then unmapped. But logging takes place in a low priority task, so it is important that no logging is done from those methods. Signed-off-by: Guennadi Liakhovetski <[email protected]>
So far we cannot build identical LLEXT modules under Linux and Windows, build a monolithic firmware for this test. Signed-off-by: Guennadi Liakhovetski <[email protected]>
If a module contains 0 as its CPC value, the consumption calculation routine will assign a "safe" maximum value to keep the DSP running at the maximum clock rate. This works when constructing a pipeline, but when a pipeline is torn down, returning the maximum clock rate leads to the clock being reduced to a small value. Fix this by detecting such cases in pipeline termination code. Signed-off-by: Guennadi Liakhovetski <[email protected]>
Make smart-amp-test, mixin-mixout and eq-iir modular on MTL. Signed-off-by: Guennadi Liakhovetski <[email protected]>
With CONFIG_SOF_TELEMETRY_PERFORMANCE_MEASUREMENTS=n compilation is currently broken, fix it. Signed-off-by: Guennadi Liakhovetski <[email protected]>
When built with performance-measurement enabled, LLEXT fails to boot. Disable CONFIG_SOF_TELEMETRY_PERFORMANCE_MEASUREMENTS until it's fixed. Signed-off-by: Guennadi Liakhovetski <[email protected]>
the last two commits fix https://sof-ci.01.org/sofpr/PR9296/build6427/devicetest/index.html |
Disabling CONFIG_KCPS_DYNAMIC_CLOCK_CONTROL appears to fix speaker-test failures with LLEXT. Signed-off-by: Guennadi Liakhovetski <[email protected]>
#9116 merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With a curious failure in #9116 I want to test whether the same kind of errors now would appear if I enable different modules. Note, that #9172 with a large number of modules was all green 2 weeks ago