ipc4: helper: fix stream params frame format update #9638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iganakov
requested review from
lgirdwood,
plbossart,
mmaka1,
lbetlej,
dbaluta and
kv2019i
as code owners
lgirdwood
approved these changes
Nov 4, 2024
dnikodem
approved these changes
Nov 5, 2024
During assignment of ipc4_base_module_cfg, received in Init Instance IPC, to sof_ipc_stream_params valid_bit_depth is used to set frame_fmt instead of container size. It is then applied to buffer format in params/prepare stage. Thus, leads to inconsistency between buffer format and audio stream params provided in IPC. Signed-off-by: Ievgen Ganakov <[email protected]>
iganakov
force-pushed
the
iganakov/fix_frame_fmt
branch
from
c365ad0 to
e1b8d23
Compare
lgirdwood
approved these changes
Nov 5, 2024
tmleman
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
ipc4_base_module_cfg_to_stream_params()which uses valid bit depth value from IPC4 base module config instead of container size (depth) to setframe_fmt.