Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

topology2: Update I2S MAX98260a, RT5682, 2 DMICs topology for PTL platform #9645

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

udaymb
Copy link
Contributor

@udaymb udaymb commented Nov 8, 2024

PTL blobs are different for I2S. This entry will create a topology for I2S MAX98360a(SSP1), RT5682(SSP0) codecs, BT at SSP2 and PDM0, PDM1 DMIC.

This also enables deep buffer for speaker and headset

@udaymb udaymb requested review from ranj063 and jsarha as code owners November 8, 2024 15:56
…tform

PTL blobs are different for I2S. This entry will create a
topology for I2S MAX98360a(SSP1), RT5682(SSP0) codecs, BT
at SSP2 and PDM0, PDM1 DMIC.

This also enables deep buffer for speaker and headset

Signed-off-by: Uday M Bhat <[email protected]>
@udaymb udaymb force-pushed the ptl-max98360-rt5682-tplg branch from cc00574 to 9e2d120 Compare November 8, 2024 15:57
Copy link
Collaborator

@kv2019i kv2019i left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good, but please check question on correct folder. These can be moved later, but just to note that files in development will not be shipped via sof-bin.

PDM1_MIC_B_ENABLE=1,DMIC0_PCM_ID=99,PREPROCESS_PLUGINS=nhlt,\
NHLT_BIN=nhlt-sof-ptl-max98360a-rt5682.bin,SPK_ID=6,DEEPBUFFER_FW_DMA_MS=10,INCLUDE_ECHO_REF=true,\
BT_NAME=SSP2-BT,BT_ID=7,BT_PCM_NAME=Bluetooth,DEEP_BUF_SPK=true"

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this intentional on "development/" (these files won't be part of upstream sof-bin releases)?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack, we can move this later.

@lgirdwood lgirdwood merged commit 7303db2 into thesofproject:main Nov 11, 2024
44 of 47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants