Check urgent #34

Wolverinese · 2025-06-28T07:24:38Z

Thanks

Summary by CodeRabbit

Chores
- Introduced automated build and test workflow for C/C++ projects, ensuring code is configured, built, tested, and validated on every push or pull request to the main branch.

Co-authored-by: Nicholas St. Germain <[email protected]>

Updated FThirdwebEngineTransactionOverrides to be fully editable in Blueprints by changing BlueprintReadOnly to BlueprintReadWrite. This allows modifying gas and transaction values directly in Unreal Engine

Make Transaction Overrides Editable in Blueprints (thirdweb-dev#31)

firing🔥$hoX.2 Signed-off-by: AA <[email protected]>

Create c-cpp.yml

coderabbitai · 2025-06-28T07:24:58Z

Walkthrough

A new GitHub Actions workflow file named c-cpp.yml was added to automate building, testing, and distribution checks for a C/C++ project. The workflow triggers on pushes and pull requests to the main branch and executes sequential steps on Ubuntu, including code checkout, configuration, build, test, and distribution validation.

Changes

File(s)	Change Summary
.github/workflows/c-cpp.yml	Added a workflow for automated build, test, and distribution checks for C/C++ using GitHub Actions.

Sequence Diagram(s)

sequenceDiagram
    participant GitHub
    participant Runner
    participant Repo

    GitHub->>Runner: Trigger workflow on push/pull_request to main
    Runner->>Repo: actions/checkout
    Runner->>Runner: Run ./configure
    Runner->>Runner: Run make
    Runner->>Runner: Run make check
    Runner->>Runner: Run make distcheck

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (5)

.github/workflows/c-cpp.yml (5)
3-8: Consider adding manual/scheduled triggers for flexibility

The workflow only fires on pushes / PRs to main.
Including workflow_dispatch: (manual) and/or schedule: (cron) triggers lets maintainers re-run CI for flaky failures or periodic checks without pushing new commits.
 on:
   push:
     branches: [ "main" ]
   pull_request:
     branches: [ "main" ]
+  workflow_dispatch:
+  schedule:
+    - cron: '0 3 * * 0'   # weekly Sunday build
9-12: Add a concurrency block to auto-cancel stale runs

Concurrent pushes to the same branch will queue duplicate builds.
Cancelling superseded jobs shortens feedback loops and reduces CI minutes.
 jobs:
   build:
+    concurrency:
+      group: ${{ github.workflow }}-${{ github.ref }}
+      cancel-in-progress: true
14-15: Cache the build directory to speed up repeated runs

Each run recompiles everything from scratch.
Leveraging the actions/cache action (e.g., on the build/ or .ccache directories) can cut build time dramatically on subsequent pushes.
     steps:
     - uses: actions/checkout@v4
+    - name: Cache build artefacts
+      uses: actions/cache@v4
+      with:
+        path: |
+          build
+          .ccache
+        key: ${{ runner.os }}-build-${{ hashFiles('**/Makefile', '**/*.c', '**/*.h') }}
+        restore-keys: |
+          ${{ runner.os }}-build-
18-19: Parallelise the make invocation

CI runners provide multiple cores; using -j$(nproc) reduces wall-clock time without additional cost.
-    - name: make
-      run: make
+    - name: make
+      run: make -j$(nproc)
20-23: make distcheck already runs make check—drop the redundant step

distcheck performs make, make check, and packaging verification internally.
Running make check separately lengthens the pipeline by ~50 %. Removing it keeps coverage identical while saving minutes.
-    - name: make check
-      run: make check

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2f309ff and a5245f0.

📒 Files selected for processing (1)

.github/workflows/c-cpp.yml (1 hunks)

🔇 Additional comments (1)

.github/workflows/c-cpp.yml (1)

14-18: Install build prerequisites before running ./configure

A bare ubuntu-latest image may miss Autotools, pkg-config, or library headers your configure script expects.
Add an explicit package-install step (or a container image) to avoid silent failures.
     - uses: actions/checkout@v4
+    - name: Install build dependencies
+      run: |
+        sudo apt-get update
+        sudo apt-get install -y build-essential autotools-dev autoconf automake libtool pkg-config

Wolverinese

Thanks

0xFirekeeper and others added 5 commits February 15, 2025 03:56

v2.0.0 (thirdweb-dev#30)

0a4d44f

Co-authored-by: Nicholas St. Germain <[email protected]>

Make Transaction Overrides Editable in Blueprints (thirdweb-dev#31)

1152ac3

Updated FThirdwebEngineTransactionOverrides to be fully editable in Blueprints by changing BlueprintReadOnly to BlueprintReadWrite. This allows modifying gas and transaction values directly in Unreal Engine

Merge pull request #1 from thirdweb-dev/main

8a550af

Make Transaction Overrides Editable in Blueprints (thirdweb-dev#31)

Create c-cpp.yml

c9479d0

firing🔥$hoX.2 Signed-off-by: AA <[email protected]>

Merge pull request #2 from Wolverinese/Wolverinese-patch-1

a5245f0

Create c-cpp.yml

coderabbitai bot reviewed Jun 28, 2025

View reviewed changes

Wolverinese commented Jun 28, 2025

View reviewed changes

Wolverinese changed the base branch from main to firekeeper/only-external-browser June 28, 2025 07:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Check urgent #34

Check urgent #34

Uh oh!

Wolverinese commented Jun 28, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Jun 28, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Uh oh!

Wolverinese left a comment

Uh oh!

Uh oh!

Check urgent #34

Are you sure you want to change the base?

Check urgent #34

Uh oh!

Conversation

Wolverinese commented Jun 28, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Jun 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Wolverinese left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Wolverinese commented Jun 28, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jun 28, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)