Remove multipart-post dependency #13
Conversation
nachojorge
force-pushed
the
remove-multipart-dependency
branch
3 times, most recently
from
8168f24 to
0c20d6c
Compare
nachojorge
force-pushed
the
remove-multipart-dependency
branch
from
0c20d6c to
a07101d
Compare
There was a problem hiding this comment.
Find the minimum possible configuration value to make rubocop pass for the next cops:
- Metrics/BlockLength
- Metrics/MethodLength
- Metrics/CyclomaticComplexity
- Metrics/AbcSize
- Metrics/ModuleLength
- Metrics/PerceivedComplexity
- Metrics/ParameterLists
| def self.normalize_headers(headers) | ||
| normalized = headers.map do |h, v| | ||
| if v.is_a?(Array) | ||
| [h, v.first] | ||
| [h, v.first] | ||
| else | ||
| [h, v] | ||
| [h, v] | ||
| end | ||
| end | ||
|
|
||
| Hash[normalized] | ||
| end |
There was a problem hiding this comment.
def self.normalize_headers(headers)
headers.transform_values{|v| v.is_a?(Array) ? v.first : v }
end
| def self.filter_response_headers(headers) | ||
| headers.select { |h, v| ALLOWED_RESPONSE_HEADERS.include?(h) } | ||
| headers.select { |h, _v| ALLOWED_RESPONSE_HEADERS.include?(h) } | ||
| end |
There was a problem hiding this comment.
def self.filter_response_headers(headers)
headers.slice(*ALLOWED_RESPONSE_HEADERS)
end
| module Angus | ||
| module Unmarshalling | ||
|
|
||
| def self.unmarshal_scalar(scalar, type) | ||
| return nil if scalar.nil? | ||
|
|
||
| case type |
There was a problem hiding this comment.
case type
when :string, :integer, :boolean, :object
scalar
when :date
Date.iso8601(scalar)
when :date_time
DateTime.iso8601(scalar)
when :decimal
BigDecimal(scalar)
else
raise ArgumentError, "Unkonwn type: #{type}"
end
| @@ -0,0 +1,41 @@ | |||
| Metrics/BlockLength: | |||
There was a problem hiding this comment.
| Metrics/BlockLength: | |
| AllCops: | |
| Exclude: | |
| - 'coverage/**/*' | |
| Metrics/BlockLength: |
| @@ -170,7 +162,7 @@ def self.get_service_definition(code_name, version = nil) | |||
| doc_url = self.doc_url(code_name, version) | |||
|
|
|||
| if doc_url.match('file://(.*)') || doc_url.match('file:///(.*)') | |||
There was a problem hiding this comment.
| if doc_url.match('file://(.*)') || doc_url.match('file:///(.*)') | |
| if doc_url.match('file:///?(.*)') |
| Metrics/AbcSize: | ||
| Enabled: false | ||
|
|
||
| Style/OptionalBooleanParameter: |
There was a problem hiding this comment.
I thinkStyle/OptionalBooleanParameter is a good cop. I would try to fix these warnings or disable them in-line in the code, but not to disable it completely.
| Style/OptionalBooleanParameter: | ||
| Enabled: false | ||
|
|
||
| Lint/RescueException: |
There was a problem hiding this comment.
I thinkLint/RescueException is a good cop. I would try to fix these warnings or disable them in-line in the code, but not to disable it completely.
| Metrics/ParameterLists: | ||
| Enabled: false | ||
|
|
||
| Lint/InheritException: |
There was a problem hiding this comment.
We need to fix classes inheriting from Exception and keep Lint/InheritException enabled.
| request | ||
| end | ||
|
|
||
| def self.build_multipart_body(params) | ||
| @boundary = "----RubyMultipartPost#{SecureRandom.hex}" |
There was a problem hiding this comment.
Not fully sure about the use of this instance variable in this module-level method. Can't it's value get modified between this assignment and its later use in the line request['Content-Type'] = "multipart/form-data; boundary=#{@boundary}"?
| @connection = PersistentHTTP.new( | ||
| :pool_size => 4, | ||
| :pool_timeout => 10, | ||
| :warn_timeout => 0.25, | ||
| :force_retry => false, | ||
| :url => url, | ||
|
|
||
| :read_timeout => timeout, | ||
| :open_timeout => timeout | ||
| pool_size: 4, | ||
| pool_timeout: 10, | ||
| warn_timeout: 0.25, | ||
| force_retry: false, | ||
| url: url, | ||
|
|
||
| read_timeout: timeout, | ||
| open_timeout: timeout |
There was a problem hiding this comment.
Why do we use these values for the proxy client?
Shouldn't we allow to customize this?
| @@ -267,7 +261,6 @@ def self.build_from_variable_fields(variable_fields_hash) | |||
| representation_object = representation_class.new(*fields.values, fields.transform_keys(&:to_s)) | |||
|
|
|||
| fields = nil | |||
| representation_class = nil | |||
There was a problem hiding this comment.
Why did we remove this? Doesn't this keep retained memory?
| RE_PATH_PARAM = /:\w+/ | ||
|
|
||
| SEVERE_STATUS_CODES = %w(500 501 503) | ||
| HTTP_METHODS_WITH_BODY = %w[post put].freeze |
There was a problem hiding this comment.
Also, why are we specifically freezing the strings if the magic comment does it for all strings in this file?
| when '.jpg' then 'image/jpeg' | ||
| when '.png' then 'image/png' | ||
| when '.gif' then 'image/gif' | ||
| else 'application/octet-stream' |
There was a problem hiding this comment.
What about pdfs or so, if we assign them as octet-streams we dont lose anything in the request?
| module Angus | ||
| module Remote | ||
|
|
||
| VERSION = '0.0.16' |
| def self.unmarshal_scalar(scalar, type) | ||
| return nil if scalar.nil? | ||
|
|
||
| case type | ||
| when :string | ||
| #scalar.force_encoding(Encoding::UTF_8) | ||
| # scalar.force_encoding(Encoding::UTF_8) |
No description provided.