Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up package json #22

Merged

Conversation

romadryud
Copy link
Contributor

@romadryud romadryud commented Apr 17, 2024

Related to

Issue #21

Notes

Before after installing packages we had more than 1000 additions in yarn.lock.

After we have less than 30 lines.

Bundle size doesn't change a lot because of good tree-shaking in the rollup. To be honest, I have the same size as before the changes.

Commits are independent, in case you want to cherry-pick some of them.

I added one commit related to a warning about source maps during the build.

Yarn used to create a lock file because it mention in package.json

Types of changes

  • 🐛 Bug fix
  • 💥 Breaking change
  • ✨ New feature
  • ♻️ Refactoring
  • 📖 Documentation

Maintainability & Security

  • 🧪 unit test

@romadryud
Copy link
Contributor Author

romadryud commented Apr 17, 2024

@thomasbrodusch Could you please review this one in free time? Thank you!

PS:
I rebased a branch to have proper commit message so that's why this is a slide in 4 hours for 2 commits :)

@romadryud romadryud force-pushed the refactor/clean-up-package-json branch from c52548f to b73490b Compare April 17, 2024 23:06
@thomasbrodusch thomasbrodusch self-requested a review April 18, 2024 09:30
Copy link
Owner

@thomasbrodusch thomasbrodusch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌱
Thanks for this work @romadryud 👍

@thomasbrodusch thomasbrodusch merged commit fdb19d0 into thomasbrodusch:develop Apr 18, 2024
1 check passed
@romadryud
Copy link
Contributor Author

@thomasbrodusch Thank you! When did you plan to release a new version of the package?

@thomasbrodusch
Copy link
Owner

I plan to add a Dependabot feature in addition to your PR to handle dependencies versioning.
When it's done I'll publish a new release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants